NVIDIA / NVIDIA/cudf

[FEA] Add `nullate` as template parameter to the primitive row operators

Open
#20,036 0 comments 1 reaction 0 assignees View on GitHub
feature request libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Is your feature request related to a problem? Please describe.**
The non-primitive row operators and row hasher accept `nullate` as a template parameter to specify whether to check for nulls. This design allows the object-oriented join APIs to enforce null handling at compile time, which mandates null checking to maintain consistent null handling between the build and probe tables. However, primitive row operators currently accept only `nullate::DYNAMIC` in their constructor, deferring null checking to runtime.

**Describe the solution you'd like**
To achieve consistency, the solution is to mimic the design of the non-primitive row operators. Specifically, add `nullate` as a template parameter to the primitive row operators. This would allow null handling to be enforced at compile time for primitive row operators as well.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.