NVIDIA / NVIDIA/cudf

Run pandas test suite a second time with fallback disabled and xfail all failing tests

Open
#19,693 6 comments 0 reactions 1 assignee Claimed by @mroeschke View on GitHub
improvement Python tests
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

With #18719 done we now run the pandas test suite with a strict xfail setting so that 1) we do not regress our support, and 2) we immediately detect when seemingly unrelated improvements to cudf result in improved pandas compatibility. Our immediate next focus is #18659, passing the entire pandas test suite by removing all of those xfails. That goal should be achievable as long as we allow for fallback. As discussed in #17458, passing the entire pandas test suite with zero fallback is probably a non-goal for us due to the massive scope of the pandas API and the many use cases that are not worthwhile for cudf to accelerate. However, we do want to ensure that 1) we also do not regress the performance of cudf.pandas by making changes that increase fallback, and 2) that we are fully aware of and can document when we accelerate pandas and when we fall back to host execution.

To that end, we should add a second run of the pandas test suite to our CI that enables failure on fallback and xfails all tests where we know that fallback currently occurs. That can be added to our CI as a second job that runs alongside the current cudf.pandas test job.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.