NVIDIA / NVIDIA/cudf

[FEA] Replace use of cudf.datasets/cudf.testing utils for generating cuDF classic test data with standard constructors

Open
#19,630 3 comments 0 reactions 0 assignees View on GitHub
feature request Python
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

Some cuDF classic unit tests construct input data using methods from

* `cudf.datasets`
* `cudf.testing._utils` e.g. `gen_rand`
* `cudf.testing.dataset_generator`

and while these methods allow creating input test data by specificity certain data characteristics, IMO

1. They are more opaque than using public cuDF Python APIs
2. Testing "data charactistics" for correctness should ideally happen in libcudf, the cuDF classic test suite should focus on testing compatibility with pandas (which understandably sometimes involves testing data characteristics)

The task is to replace usages of the above with

1. Inline the creation of input data with a public cuDF API e.g. `data = cudf.DataFrame(...)`
2. A pytest fixture that creates "generic" data if applicable

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.