NVIDIA / NVIDIA/cudf

[BUG] Stop using private RMM macros in cudf

Open
#18,189 4 comments 0 reactions 0 assignees View on GitHub
bug Java libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Describe the bug**
cuDF is using private RMM macros and should stop relying on these.

Sources:
https://github.com/search?q=repo%3Arapidsai%2Fcudf+%2F%28%3F-i%29RMM_%5BA-Z_%5D*%5C%28%2F&type=code

The specific examples I see are:

- https://github.com/rapidsai/cudf/blob/0e01c4819f0b0b8cca12981c8100374d9420edd8/cpp/src/interop/to_arrow_device.cu#L481
- https://github.com/rapidsai/cudf/blob/0e01c4819f0b0b8cca12981c8100374d9420edd8/java/src/main/native/src/RmmJni.cpp#L660
- https://github.com/rapidsai/cudf/blob/0e01c4819f0b0b8cca12981c8100374d9420edd8/java/src/main/native/src/RmmJni.cpp#L672

Pull requests like https://github.com/rapidsai/cudf/pull/18108 should be unnecessary.

**Expected behavior**
No `RMM_...` macros are used in the cudf repository.

xref: https://github.com/rapidsai/rmm/issues/1848

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.