NVIDIA / NVIDIA/cudf

[FEA] Expand clang-tidy checks

Open
#17,410 0 comments 1 reaction 0 assignees View on GitHub
feature request libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

We discussed clang-tidy during the cuDF brown bag session today. We looked at a list of suggested clang-tidy checks from @vuule and @davidwendt. These clang-tidy checks had group consensus that we should try enabling them:
- [ ] cppcoreguidelines-init-variables
- [ ] cppcoreguidelines-narrowing-conversions
- [ ] cppcoreguidelines-no-malloc
- [ ] cppcoreguidelines-pro-type-member-init
- [ ] cppcoreguidelines-slicing
- [ ] cppcoreguidelines-rvalue-param-not-moved
- [ ] cppcoreguidelines-virtual-class-destructor
- [ ] bugprone-copy-constructor-init
- [ ] bugprone-dangling-handle
- [ ] bugprone-fold-init-type
- [ ] bugprone-implicit-widening-of-multiplication-result
- [ ] bugprone-move-forwarding-reference
- [ ] bugprone-redundant-branch-condition
- [ ] bugprone-return-const-ref-from-parameter
- [ ] bugprone-too-small-loop-variable
- [ ] bugprone-unchecked-optional-access
- [ ] bugprone-use-after-move
- [ ] misc-const-correctness
- [ ] misc-definitions-in-headers
- [ ] misc-use-anonymous-namespace
- [ ] misc-use-internal-linkage

Once #17407 is merged, we can add these gradually over time. Please edit this checklist as checks are added!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.