[BUG] Converting from numeric types to fixed point types does not handle underflow/overflow
Open
bug
libcudf
- Dominant language
- C++
- Stars
- 9.8k
- Forks
- 1.1k
- Avg merge
- 3d 6m
- Merged PRs (30d)
- 278
Description
When converting floating point types to fixed point types, the casting operations are just blindly scaling the input values and then casting to integer without checking whether the scaled values are too big to be stored in the target integer types.
Probably a more proper way to do casting here is to check for underflow/overflow and nullify the output accordingly.
Contributor guide
Assessment
This issue has not been assessed yet.