NVIDIA / NVIDIA/cudf

Share struct member definition for parse_options and parse_options_view

Open
#15,825 1 comment 0 reactions 0 assignees View on GitHub
improvement libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

*question*: It seems a shame that one must repeat most of the fields between `parse_options` and `parse_options_view`. Shall we open an issue to discuss whether these should be shared with something like:

```c++
struct _parse_options {
char delimiter;
...;
...;
}

struct parse_options_view {
struct _parse_options opts;
cudf::detail::trie_view trie_true;
...;
}

struct parse_options {
struct _parse_options opts;
cudf::detail::optional_tree trie_true;
...

}
```
WDYT?

_Originally posted by @wence- in https://github.com/rapidsai/cudf/pull/15727#discussion_r1609612576_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.