NVIDIA / NVIDIA/cudf

[FEA] Stream-preserving constructors for scalar class and its derived classes

Open
#14,333 6 comments 0 reactions 0 assignees View on GitHub
feature request libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Is your feature request related to a problem? Please describe.**
When the class constructor is implicitly called (when the object is passed-by-value, for instance), the constructor is called with the default stream, and not the CUDA stream passed by the user on which the algorithm is running.
`string_scalar(string_scalar const& other,
rmm::cuda_stream_view stream = cudf::get_default_stream(),
rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource());`

**Describe the solution you'd like**
Consider requiring stream to be passed to constructor by making it a non-default argument.
`string_scalar(string_scalar const& other,
rmm::cuda_stream_view stream ,
rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource());
`

**Describe alternatives you've considered**
None

**Additional context**
None

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.