NVIDIA / NVIDIA/cudf

[FEA] Test more edge cases in bitmask operations

Open
#13,490 1 comment 0 reactions 0 assignees View on GitHub
0 - Backlog feature request libcudf Python tests
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Is your feature request related to a problem? Please describe.**
libcudf has multiple functions (both internal and external) for manipulating bitmasks. These functions often make use of bitwise operations and CUDA intrinsics in kernels, which may have sharp edges around when bitmasks contain uninitialized bits or in other ways. We recently uncovered one in #13479, and it was only uncovered via intermittent failures from dask_cudf (Python) tests.

**Describe the solution you'd like**
We should consider adding more tests that directly play with bitmasks, perhaps bitmasks containing invalid data in certain ways, to better understand the potential failure modes. In some cases these may be test cases that we do not need to support since libcudf generally follows a "garbage in, garbage out" approach, but in some cases the "garbage in" may be generated by libcudf itself and therefore something that we need to support.

I will update this issue with specific tests cases that may prove relevant:
- A bitmask with enough bits that we have > 1 CUDA block of data, and potentially with junk bits either at the beginning or the end.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.