NVIDIA / NVIDIA/cudf

[FEA] Investigate removing C++ tests of detail APIs

Open
#12,929 2 comments 1 reaction 0 assignees View on GitHub
0 - Backlog feature request libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Is your feature request related to a problem? Please describe.**
Some C++ test files are written to test detail APIs rather than public APIs. One particular example that was brought up in https://github.com/rapidsai/cudf/pull/12888#discussion_r1132719780 is [`detail_gather_tests.cu`](https://github.com/rapidsai/cudf/blob/branch-23.04/cpp/tests/copying/detail_gather_tests.cu). Ideally we should not be testing detail APIs directly, only public APIs. In practice, we should minimize cases where we must test detail APIs directly.

**Describe the solution you'd like**
We should evaluate removing tests of detail APIs. In cases where the associated public APIs are not sufficiently tested, the detail tests should be converted to test the public APIs. In other cases where the detail tests are purely redundant they should be removed. If detail APIs are being called as part of a sequence of cudf calls in a more complex test of public APIs, those calls should be rewritten to use public APIs. The remainder should be cases where detail APIs lack an exact public analog and testing the underlying APIs is valuable. We will need to assess those tests carefully.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.