NVIDIA / NVIDIA/cudf

[BUG] libcudf tests of binary operations (in `binop-compiled-test.cpp`) mostly do not test against a ground truth

Open
#12,241 0 comments 0 reactions 0 assignees View on GitHub
0 - Backlog bug libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Describe the bug**

Binary operations between columns are implemented by runtime typed dispatch to device functors in [`cpp/src/binaryop/compiled/operation.cuh`](https://github.com/rapidsai/cudf/blob/7426a06a4510280650df4cf54b76504d690c80b2/cpp/src/binaryop/compiled/operation.cuh).

Tests of this functionality compare to host-based compute, with an implementation of the functors in [`cpp/tests/binaryop/util/operation.h`](https://github.com/rapidsai/cudf/blob/7426a06a4510280650df4cf54b76504d690c80b2/cpp/tests/binaryop/util/operation.h)

This is a very weak test of correctness that really is testing:

1. Can the author of the test copy the device functor implementation into the host implementation?
2. Can the device and host compilers emit correct code for these cases?

These tests should more properly test against a ground truth (either manually constructed, or automatically).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.