[PROPOSAL] Define fixed-point types in `cudf::` namespace
Open
0 - Backlog
libcudf
proposal
- Dominant language
- C++
- Stars
- 9.8k
- Forks
- 1.1k
- Avg merge
- 3d 6m
- Merged PRs (30d)
- 278
Description
Fixed-point (decimal) types are defined in a top-level namespace `numeric` and not in the namespace `cudf`.
This shows up in the stringified type name, and violates the expectation that packages should probably keep all their definitions in a namespace owned by the package, i.e. `cudf::`.
See additional discussion: https://github.com/rapidsai/cudf/pull/12158#discussion_r1023411485
I propose moving the fixed-point code to a namespace `cudf::fixed_point` and refactoring as needed.
Contributor guide
Assessment
This issue has not been assessed yet.