NVIDIA / NVIDIA/cudf

Constructing `Column` objects from `cudf::column` should always take ownership of the null mask

Open
#11,384 7 comments 0 reactions 0 assignees View on GitHub
1 - On Deck breaking proposal Python
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

This came out of discussions in #11354. The current approach that `Column.from_unique_ptr` drops a reference to the `cudf::column`s `null_mask` if `null_count == 0` can result in use-after-free if there are also `column_view`s referencing the `column`. See discussion in https://github.com/rapidsai/cudf/pull/11354#discussion_r930808913

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.