NVIDIA / NVIDIA/cudf

[FEA] Experiment try to unify implementation of non-nested types and nested types in `cudf::contains`

Open
#11,016 3 comments 0 reactions 0 assignees View on GitHub
feature request libcudf proposal
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

Currently, `cudf::contains` implements two separate code paths for non-nested types and nested types. That requires more effort to maintain all of them, comparing to just have one code path that can handle both.

Recently, there was an attempt to use just one code path to handle all data type (ref: https://github.com/rapidsai/cudf/pull/10770#discussion_r880980883) in groupby key hashing, which reported no performance regression on basic data types. As such, we should also test and try to unify the two code paths of `cudf::contains`.

Having just one code path that handles everything, maintenance will be much easier.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.