NVIDIA / NVIDIA/cudf

Additional tests for cudf::distinct using the new row hasher

Open
#10,742 2 comments 1 reaction 2 assignees Claimed by @bdice View on GitHub
0 - Backlog improvement libcudf tests
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

#10641 adds new a new row hasher capable of natively handling nested struct and list types. The new hasher was tested by incorporating it into the implementation of `cudf::distinct`. Now that the functionality for `cudf::distinct` has been expanded by the use of this new hasher, we should add tests for some new cases, as was pointed out in some discussion threads on that PR:
- [X] We should add tests of tests with sliced input for both structs and lists input columns (https://github.com/rapidsai/cudf/pull/10641#discussion_r858037209)
- [X] We should add tests for simple nested cases like `List>` and `Struct>` to ensure that the new nesting behavior really works as expected (https://github.com/rapidsai/cudf/pull/10641#discussion_r853494994)
- [ ] We should add at least one test of a more complex nested case (e.g. `List>>>`) to potentially help catch unexpected errors (https://github.com/rapidsai/cudf/pull/10641#discussion_r853494994)

Adding these tests will be helpful to validate the behavior of the new row hasher.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.