NVIDIA / NVIDIA/cudaqx

Update CI to build hololink bridge

Open
#492 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
117
Forks
74
Avg merge
2d 7h
Merged PRs (30d)
25

Description

The build of hololink_predecoder_bridge is skipped in CI because the HSB/DOCA find_library calls live in unittests/utils/CMakeLists.txt, which is a sibling directory -- those variables aren't visible here in unittests/realtime/. The simplest fix is to move hololink_predecoder_bridge.cpp and hololink_predecoder_test.sh into unittests/utils/ alongside hololink_qldpc_graph_decoder_bridge.cpp and its orchestration script, which already has the HSB/DOCA build infrastructure. Alternatively, move the find_library/find_path blocks up into the parent unittests/CMakeLists.txt.

Originally posted by @cketcham2333 in https://github.com/NVIDIA/cudaqx/pull/490#discussion_r3052079209

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with unittests/realtime/ and unittests/utils/CMakeLists.txt, then compare the hololink_predecoder files with hololink_qldpc_graph_decoder_bridge.cpp and its orchestration script. Confirm how the HSB/DOCA find_library and find_path variables are scoped. Done means hololink_predecoder_bridge is built by CI and hololink_predecoder_test.sh runs successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.