Potential bug in simpleVulkan example
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 9.6k
- Forks
- 2.4k
- Avg merge
- 53m
- Merged PRs (30d)
- 1
Description
I found out that someone tries to compare two different enums here:
https://github.com/NVIDIA/cuda-samples/blob/4f735616ba599fe93cc2c6c85dcb4369260f9643/Samples/5_Domain_Specific/simpleVulkan/main.cpp#L331
The handleType is enum VkExternalMemoryHandleTypeFlagBits and bit VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_OPAQUE_WIN32_BIT is a VkExternalSemaphoreHandleTypeFlagBits. It probably works, but it would be nice to do bitwise and operation on enums with the same type.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open Samples/5_Domain_Specific/simpleVulkan/main.cpp around line 331 and inspect the enum types used in the comparison. Confirm the change with the simpleVulkan sample build or validation available in the repository; done means the comparison uses compatible Vulkan handle-type flags without changing the sample's intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100