VulkanBaseApp.cpp is using std::numeric_limits but not including <limits>
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 9.6k
- Forks
- 2.4k
- Avg merge
- 53m
- Merged PRs (30d)
- 1
Description
Lines 696, 1691 and 1695 of VulkanBaseApp.cpp in the simpleVulkanMMap sample are using std::numeric_limits in VulkanBaseApp.cpp but #include <limits> isn't added to correctly reference.
Please add #include <limits> in the beginning.
Anologue for the simpleVulkan sample.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open Samples/5_Domain_Specific/simpleVulkanMMAP/VulkanBaseApp.cpp and inspect the uses of std::numeric_limits at lines 696, 1691, and 1695. Add the missing include at the beginning, then check the analogous simpleVulkan sample and build both samples to confirm the include fixes compilation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100