Basis conversion too conservative?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.1k
- Forks
- 456
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 165
Description
The basis conversion pass presently is a module pass. It is a module pass because it pre-scans the entire module to determine if there are any quake::ApplyOp operation present and if so it fails to convert any of the module.
Why not just run a basis conversion as a FuncOp pass and let each thread decide if there is a blocker (like apply-op-specialization wasn't run, or inlining, or ...)? What are the issues, if any, when some of the Quake IR is basis converted while some is not?
[There is a FIXME in the code; converting it to an issue.]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the FIXME referenced in the issue and reading the basis conversion module pass, including its pre-scan for quake::ApplyOp. Compare that behavior with the FuncOp pass structure and inspect how partial basis conversion would interact with the listed blockers. Done means establishing the implications and a clear implementation direction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100