Allow decomposing gates with wires as inputs in `DecompositionPatterns`
Open
Nobody has claimed this yet.
enhancement
stale-notified
- Dominant language
- C++
- Stars
- 1.1k
- Forks
- 456
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 165
Description
Currently, all OpRewritePattern in DecompositionPatterns.cpp have the check
if (!quake::isAllReferences(op))
return failure();
disallowing WireType as gate operands.
We should be able to lift this constraint.
See the discussion in: https://github.com/NVIDIA/cuda-quantum/pull/672#discussion_r1331747540
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in DecompositionPatterns.cpp and review the discussion in PR #672, especially the linked comment. Trace each OpRewritePattern's isAllReferences check and inspect the existing decomposition tests, if present, to understand wire operands and expected behavior. Done means gates with WireType operands can be decomposed without the current guard rejecting them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100