NVIDIA / NVIDIA/cuda-quantum

Follow up work to clean up the initial implementations for run and device calls

Open
#3,312 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale-notified
Dominant language
C++
Stars
1.1k
Forks
456
Avg merge
1d 22h
Merged PRs (30d)
165

Description

Creating an issue to track some items that are left as todos in PRs:

  • In runtime/common/BaseRemoteRestQPU.h,: TODO - clean this up to not have to do this. Considering the module's map, or cudaq::details::getKernelName(). But make sure it works for
  • In runtime/common/RuntimeMLIR.cpp: FIXME: don't use a recursive walk to DFS for FuncOps, which appear as children, in a Module.
  • Add proper validation to not permit arbitrary/non-profile compliant calls in lib/Optimizer/CodeGen/VerifyQIRProfile.cpp
  • reexamine filterSpecificCodePatterns in runtime/common/RuntimeMLIRCommonImpl.h
  • get rid of --enable-run
  • eliminate the use of a range of different CUDAQ_ environment variables to manually configure the compiler (including #3223 )
  • Address https://github.com/NVIDIA/cuda-quantum/pull/3223#issuecomment-3176933095

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the TODOs in runtime/common/BaseRemoteRestQPU.h, runtime/common/RuntimeMLIR.cpp, lib/Optimizer/CodeGen/VerifyQIRProfile.cpp, and runtime/common/RuntimeMLIRCommonImpl.h, then read the discussion on PR #3223. The scope spans validation, runtime cleanup, --enable-run, and CUDAQ_ configuration; done means the listed follow-up items and the referenced comment are addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.