NVIDIA / NVIDIA/cuda-quantum

targettests/execution/to_integer.cpp test is broken

Open
#2,785 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale-notified
Dominant language
C++
Stars
1.1k
Forks
456
Avg merge
1d 22h
Merged PRs (30d)
165

Description

Disabling one of the RUN lines for now.

This test probably ought to work. A local simulator should probably be able to JIT and perform argument substitution. It's unclear why that's not been implemented.

I suspect that this test was accidentally passing by luck since the executable was returning whatever trash happened to be on the stack/registers as the return code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with targettests/execution/to_integer.cpp and inspect the disabled RUN line. Trace how the local simulator handles JIT execution and argument substitution, then verify that the test returns a deterministic integer rather than relying on stack or register contents. Done means the RUN line can be re-enabled and the test passes reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.