NVIDIA / NVIDIA/cuda-quantum

Need a way for tests to only run when the host is a particular architecture

Open
#2,276 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue stale-notified testing
Dominant language
C++
Stars
1.1k
Forks
456
Avg merge
1d 22h
Merged PRs (30d)
165

Description

Some parts of LLVM have to ability to add a line such as

REQUIRES: x86-registered-target

to the test to disable the test unless x86 is present. We need a way to be able to select between x86-64 and aarch64 (and anything new that's added) in order to write tests that prevent regressions for platform differences.

See also https://github.com/NVIDIA/cuda-quantum/actions/runs/11330747838/job/31509875881 where it looks like the assets builder may not be able to handle the if command? At any rate, we need a portable way of omitting tests when the host is not a specific architecture.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the test harness and the assets builder workflow referenced in the issue, then compare their behavior with LLVM's REQUIRES: x86-registered-target convention. Done means tests can be selected by host architecture, including x86-64 and aarch64, and are portable in the affected CI workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.