[ENHANCEMENT]: Update build-time check since the trunk CCCL allows 1B/2B `atomic_ref`
Nobody has claimed this yet.
- Dominant language
- Cuda
- Stars
- 667
- Forks
- 120
- Avg merge
- 7d 5h
- Merged PRs (30d)
- 4
Description
Is your feature request related to a problem? Please describe.
https://godbolt.org/z/a78x4qrha
Originally posted by @sleeepyjack https://github.com/NVIDIA/cuCollections/pull/549#discussion_r1684974753
Now cuda::atomic_ref can work with 1-byte and 2-byte variables so we need to update the static asserts accordingly in cuco data structures, e.g.
Describe the solution you'd like
Update build checks and unit tests
Describe alternatives you've considered
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the static assertions in include/cuco/static_map_ref.cuh and include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh, then inspect the existing build checks and unit tests. Update the checks for 1-byte and 2-byte atomic_ref variables and adjust the tests accordingly. Done means the build checks and unit tests pass with the trunk CCCL behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100