NVIDIA / NVIDIA/cuCascade

`fixed_size_host_memory_resource` could be movable

Open
#48 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

rapidsmpf request
Dominant language
C++
Stars
59
Forks
35
Avg merge
17h 38m
Merged PRs (30d)
3

Description

I feel like disabling move constructor and assignment is unnecessarily restrictive.
https://github.com/NVIDIA/cuCascade/blob/main/include/cucascade/memory/fixed_size_host_memory_resource.hpp#L202-L203

Is there any reason for it?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with include/cucascade/memory/fixed_size_host_memory_resource.hpp around lines 202-203 and inspect the surrounding resource state and ownership logic. Determine why move construction and assignment are disabled, then check whether the existing tests cover moving this resource. Done means the reason is established and the issue's requested movability is either supported with coverage or clearly documented as unsafe.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.