NVIDIA / NVIDIA/cloudai

Implement consistent model merging across the codebase

Open
#806 0 comments 0 reactions 1 assignee View on GitHub

@podkidyshev is already working on this.

Since Apr 13, 2026.

Dominant language
Python
Stars
99
Forks
62
Avg merge
6d 12h
Merged PRs (30d)
17

Description

Context

In PR #795, we implemented smarter field merging for the nsys configuration by using exclude_unset=True in the model_dump() call. This allows partial overrides of nsys fields in scenario configurations while preserving base values from test definitions.

A similar approach was previously used for reports. However, the current approach for most other fields is "all or nothing" - meaning everything should be set at one level or another.

Proposal

Implement a consistent model merging strategy across the codebase:

  1. Consider creating a unified merge_models(tdef, tscenario) function or similar utility
  2. Apply the smarter merge approach consistently for all relevant model fields
  3. Ensure the merging hierarchy is clear and well-documented

This would provide a friendlier and more intuitive user experience when overriding configuration values.

References

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.