NVIDIA / NVIDIA/cccl

[FEA]: Cleanup unneeded user defined destructors on thrust

Open
#595 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.5k
Forks
486
Avg merge
2d 6h
Merged PRs (30d)
295

Description

### Is this a duplicate?

- [X] I confirmed there appear to be no [duplicate issues](https://github.com/NVIDIA/cccl/issues) for this request and that I agree to the [Code of Conduct](CODE_OF_CONDUCT.md)

### Area

Thrust

### Is your feature request related to a problem? Please describe.

Thrust is often defining empty destructors `~meow(){}`

This is actually a potential pessimization so we should remove those occurences

### Describe the solution you'd like

Remove all empty destructors as they can be compiler provided.

We need to make sure that they are not intentionally dropping destructors of inherited classes, but that would be a whole other set of problems

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.