Feature: --fail-on severity exit code and versioned JSON schema
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 11
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Problem
- The README names CI gating as a goal, but
--jsonhas no severity-based exit code and no versioned schema other tools can depend on. - There is no clean checkpoint before
git send-emailorb4.
Proposal
- Add
--fail-on=critical|high|medium|lowso boro exits non-zero when a surviving finding meets the threshold. Default stays today's always-zero behavior. - Stamp the
--jsondocument with aschema_versionfield. - Together this makes boro usable as a pre-send check or a CI step, and gives downstream tools a stable contract.
Before / after
Before: After:
boro review --json ... boro review --json --fail-on=high ...
-> always exit 0 -> exit 1 if a High survives
-> schema informal -> {"schema_version":1, ...}
Notes
- Reuses the existing per-severity counts, so no new analysis is needed.
- Opt-in and additive, no change to the review pipeline.
- Pairs naturally with a report-diffing command as a stable consumer.
If approved, I would be willing to implement this feature.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the boro review entry point and trace how --json output, existing per-severity counts, and process exit status are handled. Done means --fail-on remains opt-in, matching surviving findings produce a non-zero exit, and JSON output includes schema_version while default behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100