[rfc][transformer][test] Make test flexible
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9k
- Forks
- 1.5k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 3
Description
Currently apex.transformer test assumes NCCL backend as you can see in:
- https://github.com/NVIDIA/apex/blob/2b7d280ba53898f0b332b7ee02068e4f737d13c9/apex/transformer/testing/distributed_test_base.py#L11
- https://github.com/NVIDIA/apex/blob/2b7d280ba53898f0b332b7ee02068e4f737d13c9/apex/transformer/testing/distributed_test_base.py#L40-L51
By renaming BACKEND_NCCL to e.g. DIST_BACKEND and replacing DistributedTestBase.BACKEND_NCCL with self.DIST_BACKEND, the test can be run with backends other than nccl.
cc @eqy @ptrblck
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with apex/transformer/testing/distributed_test_base.py, especially the backend definition around line 11 and the references around lines 40-51. Replace the NCCL-specific test backend references with a configurable backend as described in the issue, then run the apex.transformer distributed tests to confirm they can use a backend other than NCCL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- distributed-systems, testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100