NVIDIA / NVIDIA/accelerated-computing-hub
Remove obsolete port-binding rewrite from brev/dev-start.bash
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 2k
- Forks
- 338
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 16
Description
Problem
PR #208 changed the tutorial Compose files so their published services bind directly to 0.0.0.0. brev/dev-start.bash still creates /tmp/docker-compose.<tutorial>.dev.yml and runs sed to rewrite 127.0.0.1 to 0.0.0.0 before every start. That rewrite is now a no-op and the temporary file obscures the Compose file actually being run.
Proposed change
Remove DOCKER_COMPOSE_DEV and the sed rewrite, and run Compose against the prepared tutorial Compose file directly. Preserve the existing warning filtering.
Acceptance criteria
dev-start.bashworks with--mountand--no-mount.- Jupyter and Nsight services remain reachable externally.
- No temporary Compose file is created only to rewrite host bindings.
Follow-up to #208.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with brev/dev-start.bash and trace how it prepares and invokes the tutorial Compose file, including the existing warning filtering. Exercise the script with both --mount and --no-mount, then verify that Jupyter and Nsight remain externally reachable and that no temporary rewrite file is created.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, docker-compose
- Domain
- devops
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100