NVIDIA / NVIDIA/TensorRT

TREX(`trt-engine-explorer`): fix matadata typo (breaks report_card) and compatibility between dtale and dash

Open
#4,578 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Module:TREx
Dominant language
C++
Stars
13.4k
Forks
2.4k
Avg merge
5d 3h
Merged PRs (30d)
2

Description

I’m opening this issue in case it helps someone. If it’s useful, I’m happy to put together a PR.

Summary

In detail

1) Typo: matadata

There are a few occurrences of matadata in trex/report_card.py.
This leads to a runtime error when calling report_card_draw_plan_graph_extended:

Example error stack (abbreviated):

.../trex/graphing.py:832 in to_dot
g = DotGraph(*args, **kwargs)
TypeError: DotGraph.__init__() got an unexpected keyword argument 'display_matadata'

Proposed fix
Rename all matadata to metadata across TREX code where used.

2) dtaledash compatibility

dtale imports dash.development.component_loader, which was removed in dash 3.0+.
With dash ≥ 3.0, this raises:

AttributeError: module 'dash.development' has no attribute 'component_loader'

Proposed fix
We can fix it in two ways
(1) Update the dtale version (fix https://github.com/man-group/dtale/issues/904)

# requirements-notebook.txt
dtale==3.18.2 # okay only if higher than 3.17.0

(2) Or pin dash to the last 2.x release in the notebook environment:

# requirements-notebook.txt
dash==2.18.2

This keeps dtale operational without changes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tools/experimental/trt-engine-explorer/trex/report_card.py and trace report_card_draw_plan_graph_extended through the reported DotGraph error. Then inspect tools/experimental/trt-engine-explorer/requirements-notebook.txt and verify the selected dtale and dash versions are compatible; done means the report-card path no longer raises the displayed errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.