NVIDIA / NVIDIA/TensorRT

TRex package contains functions that do not work as expected.

Open
#4,161 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triaged
Dominant language
C++
Stars
13.4k
Forks
2.4k
Avg merge
5d 3h
Merged PRs (30d)
2

Description

Description

The trex.df_preprocessing module contains two functions that do not perform as expected: clean_df and clean_for_display.

The clean_df function includes an unintended list comprehension that fails to properly clean up the dataframe by removing columns.
This issue also affects the clean_for_display function.

Environment

TensorRT Version: 8.2

NVIDIA GPU: Jetson Nano developer kit (4 GB RAM), Jetpack 4.6.4

NVIDIA Driver Version: Jetson Nano developer kit (4 GB RAM), Jetpack 4.6.4

CUDA Version: 10.2.300

CUDNN Version: 8.2.1.32

Operating System: Jetpack 4.6.4, L4T 32.7.4

Python Version (if applicable): 3.10.15

Baremetal or Container (if so, version): Baremetal

Steps To Reproduce

  • Generate an Engine Plan as described in tools/experimental/trt-engine-explorer/notebooks/tutorial.ipynb.
  • Check which columns should be deleted with clean_for_display function.

As an alternative execute the following block of code, which includes the list comprehension copied from clean_df function.

from trex.df_preprocessing import layer_attributes
columns = set([col for col_list in layer_attributes.keys() for col in col_list])
print(columns)
Result is:
     {'2', 'C', 'S', 'R', 'P', 'W', 'V', 'c', 'a', 'g', 'f', 'e', 'i', 'h', 'o', 'n', 'm', 'l', 's', 'r', 'v', 'u', 't', 'z'}
Should be:
    ['subtype', 'Groups', 'OutMaps', 'Stride', 'Kernel', 'HasBias', 'Activation', 'HasReLU', 'PaddingMode', 'PrePadding', 'PostPadding', 'Dilation', 'AllowSparse', 'Weights', 'Bias', 'Dimensions', 'ConvolutionTacticIndex', 'Operations', 'NbOperations', 'Operations', 'NbOperations', 'NbInputArgs', 'InputArgs', 'NbOutputVars', 'OutputVars', 'NbLiterals', 'Literals', 'NbParams', 'Params', 'Instructions', 'NbInstructions', 'NbInputs', 'InputArgs', 'NbOutputVars', 'OutputVars', 'NbLiterals', 'Literals', 'NbParams', 'Params', 'Origin', 'PoolingType', 'WindowSize', 'AverageCountExcludesPadding', 'PaddingMode', 'Stride', 'PrePadding', 'PostPadding', 'BlendFactor', 'Mode', 'Shift', 'Scale', 'Power', 'Activation', 'ChannelAxis', 'FirstTranspose', 'SecondTranspose', 'Reshape', 'ZeroIsPlaceholder', 'ParameterSubType', 'ResizeMode', 'ResizeScales', 'NNRounding', 'Start', 'CoordTransform', 'ResizeSelector', 'Start', 'Stride', 'Size', 'Mode', 'negativeInfinityPadding', 'ParameterType', 'weights', 'dimensions', 'TacticValue']

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the trex.df_preprocessing module by examining clean_df and clean_for_display, then reproduce the issue with the list comprehension shown in the report or tools/experimental/trt-engine-explorer/notebooks/tutorial.ipynb. Done means both functions identify and remove the expected dataframe columns rather than individual characters.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.