NVIDIA / NVIDIA/TensorRT-LLM

[Feature]: AutoDeploy: discussion where/how/when to enforce strict export IR

Open
#9,956 3 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

AutoDeploy feature request
Dominant language
Python
Stars
14.7k
Forks
2.8k
Avg merge
2d 23h
Merged PRs (30d)
489

Description

🚀 The feature, motivation and pitch

Right now, we technically impose a strict requirement to keep our fx graph consistent with the export IR specifications. However, we already break this assumption in multiple places and hence should revisit this assumption

  1. Quasi-dynamic shapes in prepare_metadata and using batch_info tensor to split sequences
  2. In-place update with cuda_cached_causal_conv
  3. Irregular function for gather_logits with undeclared dynamic shape

Let's revisit the assumption of enforcing a strict export IR during/after transforms!

Alternatives

No response

Additional context

No response

Before submitting a new issue...
  • Make sure you already searched for relevant issues, and checked the documentation and examples for answers to frequently asked questions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.