NVIDIA / NVIDIA/TensorRT-LLM

[Bug]: AutoDeploy: torch-compile: fix fake ops for prepare_metadata and other ops

Open
#9,878 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

bug Infra triaged
Dominant language
Python
Stars
14.7k
Forks
2.8k
Avg merge
2d 23h
Merged PRs (30d)
489

Description

System Info

Fake ops for our prepare_metadata ops are not correct since the shapes are dependent on the input values of the tensors. This will cause torch-compile to fail.

There is two potential ways we can consider fixing it:

  1. Hack to see if we can trick the torch-compile shape analysis
  2. Properly declare additional dynamic shapes that will correctly describe the metadata

This should probably also tie into our discussion of how and if we want to use torch-compile at all moving forward...

Who can help?

No response

Information
  • The official example scripts
  • My own modified scripts
Tasks
  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)
Reproduction

n/a

Expected behavior

n/a

actual behavior

n/a

additional notes

n/a

Before submitting a new issue...
  • Make sure you already searched for relevant issues, and checked the documentation and examples for answers to frequently asked questions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.