NVIDIA / NVIDIA/TensorRT-LLM

[Feature]: AutoDeploy: align AD LlmArgs more closely with PT LlmArgs

Open
#9,306 5 comments 1 reaction 1 assignee View on GitHub

A pull request for this has already been merged.

  • #10613 by @2ez4bz — merged
AutoDeploy feature request
Dominant language
Python
Stars
14.7k
Forks
2.8k
Avg merge
2d 23h
Merged PRs (30d)
489

Description

🚀 The feature, motivation and pitch

Now that PT LlmArgs have mostly stabilized, let's see if we can more closely align AD LlmArgs with PT LlmArgs:

  1. Deprecate AutoDeployConfig as separate class and just move it all into AD's LlmArgs class
  2. Align any field in AD's LlmArgs if there is a corresponding field in PT
  3. Consider inheriting from PT's LlmArgs instead of BaseLlmArgs

This help ensuring AD can serve as a drop-in replacement for PT backend where needed and simplify integration management (trtllm-serve, trtllm-bench, dynamo, NIM, ...)

Alternatives

No response

Additional context

No response

Before submitting a new issue...
  • Make sure you already searched for relevant issues, and checked the documentation and examples for answers to frequently asked questions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.