NVIDIA / NVIDIA/TensorRT-LLM

[Bug]: Support parameters sharding across safetensors

Open
#11,541 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Disaggregated serving
Dominant language
Python
Stars
14.7k
Forks
2.8k
Avg merge
2d 23h
Merged PRs (30d)
489

Description

System Info

NA

Who can help?

No response

Information
  • The official example scripts
  • My own modified scripts
Tasks
  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)
Reproduction

use HF model that has sharded params. for example nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-NVFP4.

Expected behavior

linear op params should be initialized correctly

actual behavior

linear op params aren't initialized correctly

additional notes

When AD deals with quantized here it expects all parameters to be available in the same state_dict. when a linear op's params are sharded across safetensors, this means the condition isn't triggered, and the params for that linear aren't initialized.

Need to make the load_hook robust to these kind of scenearios

Before submitting a new issue...
  • Make sure you already searched for relevant issues, and checked the documentation and examples for answers to frequently asked questions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the quantization logic in tensorrt_llm/_torch/auto_deploy/transform/library/quantization.py around the linked code, then trace the load_hook handling the state_dict. Reproduce with nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-NVFP4 and verify that linear parameters split across safetensors are initialized correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.