NVIDIA / NVIDIA/TensorRT-LLM

[Feature]: Improved custom model registration

Open
#11,071 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

feature request Model customization
Dominant language
Python
Stars
14.7k
Forks
2.8k
Avg merge
2d 23h
Merged PRs (30d)
489

Description

🚀 The feature, motivation and pitch

When implementing a drafter factory for Eagle models, we had to load a custom model definition, and opted to make a factory to reduce hacks introduced to the AutoModelForCausalLMFactory (see: https://github.com/NVIDIA/TensorRT-LLM/pull/10674#discussion_r2728071770).

In general, it seems unsustainable to have to make a factory for each new model. We should consider a cleaner way to load custom models without introducing corner cases and specific workarounds to AutoModelForCausalLMFactory

Alternatives

No response

Additional context

No response

Before submitting a new issue...
  • Make sure you already searched for relevant issues, and checked the documentation and examples for answers to frequently asked questions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.