NVIDIA / NVIDIA/TensorRT-LLM

[Feature]: AutoDeploy: load_hook hierarchy

Open
#10,348 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

AutoDeploy feature request
Dominant language
Python
Stars
14.7k
Forks
2.8k
Avg merge
2d 23h
Merged PRs (30d)
489

Description

🚀 The feature, motivation and pitch

Right now, we register all load hooks in the parent module (the parent GM). This can cause issues in the order of load hooks. Broadly speaking load hook order is as follows:

  1. Load hooks in parent modules before load hooks in children modules
  2. Order of registration of load hooks

Right now, registering everything in the parent GM can cause issues if for example a custom modeling code has load hooks in the child class, e.g., see this issue: https://nvidia.slack.com/archives/C08T55LHSG4/p1767113040245849?thread_ts=1766676954.143199&cid=C08T55LHSG4

Alternatives

No response

Additional context

No response

Before submitting a new issue...
  • Make sure you already searched for relevant issues, and checked the documentation and examples for answers to frequently asked questions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.