NVIDIA / NVIDIA/OpenShell

ci: make Nix test guest image pins resilient

Open
#3,005 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

state:stale
Dominant language
Rust
Stars
8.7k
Forks
1.3k
Avg merge
2d 11h
Merged PRs (30d)
253

Description

Description

The Nix-managed test guest definitions fetch Ubuntu cloud images from mutable release URLs with fixed-output hashes. When Ubuntu republishes an image at the same URL, Nix correctly rejects the download with a hash mismatch and the VM E2E lane fails before tests start.

Context

PR #3004 exposed this in the rootless Podman Ubuntu 26.04 Nix VM lane. The failing job was e2e / E2E (rust-podman-rootless, Ubuntu 26.04 Nix VM) in run https://github.com/NVIDIA/OpenShell/actions/runs/33151151454.

The amd64 Ubuntu 26.04 cloud image pin in nix/test-guest/distros/ubuntu-26-04.nix expected:

sha256-ncfFNjwBRqCLoMmqg02CwsbfuxxHGtmi8KuhGJ4hvgU=

CI downloaded bytes with:

sha256-gZa+nXlYBZy1bGx1yA/fbO6KiIW8FJ6nkdfbHH75MDU=

This prevented the VM image from building, so the guest E2E launcher and Rust tests never ran.

Definition of Done

  • Test guest distro definitions use immutable image references, a project-controlled mirror, or another mechanism that avoids unexpected breakage when upstream release URLs are republished.
  • CI failure output for image hash mismatches points maintainers to the exact distro definition and recovery path.
  • The documented update workflow covers both amd64 and arm64 guest image hashes.
  • The rootless Podman Ubuntu 26.04 Nix VM E2E lane can build its guest image without relying on mutable upstream bytes staying unchanged.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with nix/test-guest/distros/ubuntu-26-04.nix and the failing e2e / E2E (rust-podman-rootless, Ubuntu 26.04 Nix VM) job; inspect how the amd64 and arm64 image references and hashes are selected. Reproduce the image build, then verify the documented recovery/update workflow, hash-mismatch guidance, and successful guest build for the lane.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, linux, rust
Domain
build-system, ci-cd, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.