refactor(prover): define and surface accepted-risk provenance
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 8.7k
- Forks
- 1.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 253
Description
Description
Define how accepted-risk attribution is retained and surfaced when findings are accepted.
The accepted-risk loader parses accepted_by, but matching and rendering never use it. Fully accepted findings retain only one reason, and partially accepted findings discard the provenance of the paths that matched accepted-risk entries.
Context
Identified while reviewing the call chain rooted at prove() after #2395.
Relevant code:
crates/openshell-prover/src/accepted_risks.rscrates/openshell-prover/src/finding.rscrates/openshell-prover/src/report.rs
This is audit-facing behavior, so the representation should be agreed before implementation. In particular, define whether provenance belongs on findings, individual paths, or a separate acceptance result.
Definition of Done
- Define the accepted-risk provenance model, including
accepted_byand reason. - Preserve provenance when multiple accepted-risk entries match.
- Define and preserve provenance for partially accepted findings.
- Surface the agreed attribution in relevant report or structured output.
- Tests cover complete, partial, pathless, and multiple-entry acceptance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the call chain rooted at prove() and read crates/openshell-prover/src/accepted_risks.rs, finding.rs, and report.rs first. Establish the accepted-risk provenance model before implementation, including complete, partial, pathless, and multiple-entry matches. Done means provenance is preserved and surfaced in relevant report or structured output, with tests covering those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100