typeToString raises for the OWL_DOUBLE types
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 46
- Forks
- 14
- Avg merge
- 12d 20h
- Merged PRs (30d)
- 2
Description
typeToString in owl/Object.cpp has no cases for OWL_DOUBLE, OWL_DOUBLE2, OWL_DOUBLE3 and OWL_DOUBLE4, so it ends up in the default branch and raises:
std::string owl::typeToString(OWLDataType): not yet implemented for type #1052
It is mostly called while building error messages, for example "trying to set variable to value of wrong type" in Variable.cpp, so with a double variable that error is replaced by the one above. sizeOf got the double types in #26, and Variable.cpp already handles them, so this is the last switch that misses them.
I have a small fix ready and will open a PR for it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in owl/Object.cpp at typeToString(OWLDataType), then compare the existing handling in sizeOf and Variable.cpp for OWL_DOUBLE, OWL_DOUBLE2, OWL_DOUBLE3, and OWL_DOUBLE4. Done means typeToString no longer reaches its default error for these types and wrong-type error messages can be built for double variables.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100