NVIDIA / NVIDIA/NeMo-Retriever
[BUG]: Lazy load milvus
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3k
- Forks
- 349
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 116
Description
Version
25.6.2
Which installation method(s) does this occur on?
No response
Describe the bug.
pymilvus is marked as an optional dependency in the toml -
[project.optional-dependencies]
milvus = [
"pymilvus==2.5.10",
"pymilvus[bulk_writer,model]",
"langchain-milvus>=0.1.10",
]
and its loaded without any condition here -
https://github.com/NVIDIA/nv-ingest/blob/release/25.6.2/client/src/nv_ingest_client/client/interface.py#L42
https://github.com/NVIDIA/nv-ingest/blob/release/25.6.2/client/src/nv_ingest_client/util/vdb/__init__.py#L2
If its optional, please load it only if the vdb_upload stage is being used... this is causing issues and i need to add this dependency although i don't need it
Minimum reproducible example
Relevant log output
Other/Misc.
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading client/src/nv_ingest_client/client/interface.py and client/src/nv_ingest_client/util/vdb/init.py, focusing on where pymilvus is imported. Reproduce an import or client setup without the optional Milvus dependency, then verify that pymilvus loads only when the vdb_upload stage is used.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100