NVIDIA / NVIDIA/NeMo-Retriever
[BUG]: Paddle Version checking can get into an infinite loop when failing or PADDLE_HTTP_ENDPOINT is not specified
Open
@edknv is already working on this.
Since Oct 24, 2024.
bug
- Dominant language
- Python
- Stars
- 3k
- Forks
- 349
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 116
Description
Version
24.10
Which installation method(s) does this occur on?
Docker
Describe the bug.
The paddle version check requires the HTTP endpoint, if it is not specified (or doesn't exist), the progress engine will wait/retry forever.
Proposed solution
- Make
PADDLE_HTTP_ENDPOINTa required parameter in the paddle schema - Set some kind of maximum threshold on the @backoff decorator (maybe configurable?) so that if we fail to get the version after 5-10 minutes we fail the job.
Minimum reproducible example
No response
Relevant log output
No response
Other/Misc.
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.