NVIDIA / NVIDIA/NeMo-Retriever

[FEA]: Improve milvus connection logging

Open
#173 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Python
Stars
3k
Forks
349
Avg merge
1d 23h
Merged PRs (30d)
116

Description

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Would be nice

Please provide a clear description of problem this feature solves

Even when the nv-ingest container is successfully launched, the log shows

nv-ingest-ms-runtime-1  | 2024-10-16 19:37:12,116 - ERROR - Failed to create new connection using: ece0745f72fd43e1ba331491b9b71eb8
nv-ingest-ms-runtime-1  | 2024-10-16 19:37:12,116 - ERROR - Failed to connect to milvus: <MilvusException: (code=2, message=Fail connecting to server on milvus:19530. Timeout)>
Describe the feature, and optionally a solution or implementation and any alternatives

It says ERROR but it is intended behavior (when there is no milvus service running, it is simply logged and the pipeline is built successfully). We should imporve logging so it's not confusing to the user.

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Python code that creates the Milvus connection and emits the shown ERROR messages during nv-ingest runtime startup. Reproduce the startup with no Milvus service, then adjust the logging so this expected condition is not misleading while genuine connection failures remain visible; verify that the pipeline still builds successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, databases, observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.