NVIDIA / NVIDIA/NeMo-Retriever

[BUG]: Retry for GRPC errors still at 5 but not 10

Open
#1,139 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
3k
Forks
349
Avg merge
1d 23h
Merged PRs (30d)
116

Description

Version

Main

Which installation method(s) does this occur on?

No response

Describe the bug.

When we run into GRPC errors, we seem to be only trying till 5 attempts instead of expected 10 based on changes here:

https://github.com/VibhuJawa/nv-ingest/blob/df142488f2110e1bbf449fde6613da6e5f47b461/api/src/nv_ingest_api/internal/primitives/nim/nim_client.py#L50-L51

Maybe its hitting max_429 retries??

Minimum reproducible example

Relevant log output

Other/Misc.

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading api/src/nv_ingest_api/internal/primitives/nim/nim_client.py around lines 50-51, then trace how GRPC errors and max_429 retries are counted. Reproduce or inspect the retry behavior to determine why it stops at five attempts. Done means the relevant GRPC retry path consistently makes the expected ten attempts.

Written by the indexing model from the issue text.

Assessment

Tech stack
grpc, python
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.