NVIDIA / NVIDIA/NeMo-Retriever

[BUG]: Redis SSL fails and isn't defined correctly for a connection pool

Open
#1,073 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
3k
Forks
349
Avg merge
1d 23h
Merged PRs (30d)
116

Description

Version

25.4.2

Which installation method(s) does this occur on?

No response

Describe the bug.

When enabling the environment variable REDIS_USE_SSL, redis throws the exception 'got an unexpected keyword argument 'ssl''. In the documentation for redis connection pool https://redis.readthedocs.io/en/stable/connections.html#redis.connection.ConnectionPool: "By default, TCP connections are created unless connection_class is specified. Use class:.UnixDomainSocketConnection for unix sockets. SSLConnection can be used for SSL enabled connections.".

So it would seem the correct way to enable ssl with a redis connection pool is to pass the connection_class.

Minimum reproducible example

Relevant log output

Other/Misc.

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the handling for REDIS_USE_SSL and the Redis connection-pool setup, then compare it with the redis-py connection documentation linked in the issue. The work is done when enabling REDIS_USE_SSL establishes an SSL connection without the unexpected keyword argument error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, redis
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.