NVIDIA / NVIDIA/Megatron-LM

Move argument validation into dataclass post-init

Open
#3,568 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
17.9k
Forks
4.5k
Avg merge
4d 6h
Merged PRs (30d)
271

Description

Currently, various assertions and validations occur in `validate_args()` in `arguments.py` immediately after args are parsed. These should be migrated to the dataclasses' post-init/finalize functions. Assertions that cut across multiple configs should live in ConfigContainer post-init/finalize.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.