NVIDIA / NVIDIA/Megatron-LM

[QUESTION] Why not gather routing_map in sequence_load_balancing_loss_func function

Open
#1,406 7 comments 0 reactions 1 assignee Claimed by @ilml View on GitHub
community-request module: moe question waiting-on-maintainers
Dominant language
Python
Stars
17.9k
Forks
4.5k
Avg merge
4d 6h
Merged PRs (30d)
271

Description

**Why not gather routing_map in sequence_load_balancing_loss_func function **

Here is the code at https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/core/transformer/moe/moe_utils.py#L117
Here do a gather for 'probs_for_aux_loss' but not for 'routing_map'. Why? Shouldn't it be the same?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.