NVIDIA / NVIDIA/AMGX

configs files in src/configs are duplicate

Open
#333 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
692
Forks
197
PR merge metrics
No merged PRs in 30d

Description

Hi,

I have notives that the following pairs of files found at src/configs/

PCG_CLASSICAL_W_JACOBI.json, PCG_W.json
PCG_CLASSICAL_F_JACOBI.json, PCG_F.json

corresponds to exactly the same parameters. On the other hand:

PCG_CLASSICAL_V_JACOBI.json has a supplementary parameter "aggressive_levels": 2 compared to PCG_V.json .

Is this intended ? What is the difference supposed to be between these sets of config files ?

Cheers,
Rémi

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by diffing the four named files in src/configs: PCG_CLASSICAL_W_JACOBI.json, PCG_W.json, PCG_CLASSICAL_F_JACOBI.json, and PCG_F.json, then compare the V variants mentioned in the issue. Determine whether the duplicate parameter sets are intentional and document the confirmed distinction or cleanup needed; the issue is complete when the configuration relationship is unambiguous.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
hpc
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.