NVIDIA-RTX / NVIDIA-RTX/Streamline_Sample

Docs out of date for NRD integration, and no reference NRD implementation exists either

Open
#4 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
39
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Hi there, I'm switching from my old (outdated) NRD integration because it changes too often and is way too much maintenance overhead, so I figured SL would help me out here, but the docs for NRD use deprecated API features and there's no clear way to actually set the NRD constants via a function stub, like there are for the other features.

https://github.com/NVIDIAGameWorks/Streamline/blob/main/docs/ProgrammingGuideNRD.md

Specifically slSetFeatureConstants is gone now in 2.10:

image

I implemented setting the NRD specific constants like this:

image

image

image

Is this correct? I read all the docs and it seems to be the way to do it, but it's odd that there's no function stub in the sl.nrd.h for the function call to set the parameters.

My code seems to set the parameters properly, but then I get some weird exception when I do the actual denoising:

image

Is there a chance you would consider making an NRD integration in the sample here? It's the only feature missing a reference implementation.

The Path Tracing SDK also uses StreamLine but has a direct NRD integration and I haven't been able to find anything on Github where NRD is integrated via SL as opposed to directly.

Is anybody out there using SL for NRD feature but me? It seems not. I searched in Github for sl::kFeatureNRD and the only hits are in this repo.

Thanks in advance!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with docs/ProgrammingGuideNRD.md and sl.nrd.h, focusing on the deprecated slSetFeatureConstants API and the NRD parameter-setting approach described in the issue. Reproduce the reported denoising exception using the referenced sample context, then compare the integration with other feature examples. Done means the NRD documentation is current and the sample contains a working reference integration.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.